Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:852882] [1/2] dbus: add dbus-over-tcp support #69

Open
wants to merge 5 commits into
base: workflow
Choose a base branch
from

Conversation

IWDTestBot
Copy link
Owner

l_dbus_new() will now accept tcp endpoints, however it will only accept
a numeric address for 'host'; it will not resolve hostnames. This is so
we can avoid a potential long, blocking call to getaddrinfo().

The connect() call to the host is also non-blocking. This means that
auth will not happen until you start the event loop (with a call to
l_main_run() et. al.).

Co-authored-by: Ramon Ribeiro rhpr@cesar.org.br

ell/dbus.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 111 insertions(+)

jprestwo and others added 5 commits April 25, 2024 10:14
l_dbus_new() will now accept tcp endpoints, however it will only accept
a numeric address for 'host'; it will not resolve hostnames. This is so
we can avoid a potential long, blocking call to getaddrinfo().

The connect() call to the host is also non-blocking. This means that
auth will not happen until you start the event loop (with a call to
l_main_run() et. al.).

Co-authored-by: Ramon Ribeiro <rhpr@cesar.org.br>
Co-authored-by: Ramon Ribeiro <rhpr@cesar.org.br>
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 0.00 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 43.97 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 42.93 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 30.95 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 2.86 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 95.48 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1858.91 seconds
Result: PASS

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 72.29 seconds
Result: FAIL

Output:

ell/dbus.c:1217:19: error: variable 'dbus' is used uninitialized whenever 'for' loop exits because its condition is false [-Werror,-Wsometimes-uninitialized]
        for (iter = res; iter; iter = iter->ai_next) {
                         ^~~~
ell/dbus.c:1241:9: note: uninitialized use occurs here
        return dbus;
               ^~~~
ell/dbus.c:1217:19: note: remove the condition if it is always true
        for (iter = res; iter; iter = iter->ai_next) {
                         ^~~~
ell/dbus.c:1178:21: note: initialize the variable 'dbus' to silence this warning
        struct l_dbus *dbus;
                           ^
                            = NULL
1 error generated.
make[1]: *** [Makefile:2560: ell/dbus.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1716: all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants