Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:804365] [1/6] ie: Move AKM suite converter from netdev #269

Open
wants to merge 14 commits into
base: workflow
Choose a base branch
from

Conversation

IWDTestBot
Copy link
Owner

It is more logical to host this function inside ie.c than netdev.c.
Particularly since ie_rsn_cipher_suite_to_cipher is already present in
ie.c.

src/ie.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
src/ie.h | 2 ++
src/netdev.c | 47 +----------------------------------------------
3 files changed, 49 insertions(+), 46 deletions(-)

denkenz and others added 14 commits November 23, 2023 15:22
This is taken care of by the individual cache items and
if none exist, tar fails.
It is more logical to host this function inside ie.c than netdev.c.
Particularly since ie_rsn_cipher_suite_to_cipher is already present in
ie.c.
vendor_ies stored in handshake_state are already added as part of
netdev_populate_common_ies(), which is already invoked by
netdev_build_cmd_connect().

Normally vendor_ies is NULL for OWE connections, so no IEs are
duplicated as a result.
In netdev_retry_owe, if l_gen_family_send fails, the connect_cmd is
never freed or reset.  Fix that.

While here, use a stack variable instead of netdev member, since the use
of such a member is unnecessary and confusing.
ssid is declared as a 32 byte field in handshake_state, hence using it
as a string which is assumed to be nul-terminated will fail for SSIDs
that are 32 bytes long.

Fixes: 1f14782 ("wiphy: add _generate_address_from_ssid")
Fixes: 5a1b118 ("netdev: support per-network MAC addresses")
ssid is declared as a 32 byte field in handshake_state, hence using it
as a string which is assumed to be nul-terminated will fail for SSIDs
that are 32 bytes long.

Fixes: d938d36 ("erp: ERP implementation and key cache move")
Fixes: 433373f ("eapol: cache ERP keys on EAP success")
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.06 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 54.58 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 12.65 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 2.52 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 93.95 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 301.30 seconds
Result: PASS

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.29 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 5.82 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 37.90 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.20 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.27 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 76.45 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 244.13 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1728.69 seconds
Result: FAIL

Output:

testOWE

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 84.71 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from 48509c4 to 6787d1d Compare December 1, 2023 16:38
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 935d6cc to 1efe833 Compare December 13, 2023 16:28
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from a6b078e to 1c88fa1 Compare December 20, 2023 02:00
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 9299531 to a52506c Compare January 1, 2024 02:42
@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from 61cb7e5 to ede3c3a Compare August 23, 2024 17:32
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 8991f76 to ca0eb77 Compare September 3, 2024 15:26
@github-actions github-actions bot force-pushed the workflow branch 8 times, most recently from aada677 to 1163d8b Compare September 11, 2024 16:00
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from cd38a46 to a84ea46 Compare September 25, 2024 15:00
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 9ef1a07 to b2ed861 Compare October 8, 2024 16:33
@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from 0375753 to 7e9a794 Compare October 24, 2024 21:25
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from d961fcd to bd89ecb Compare November 13, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants