bundling #19
Merged
bundling #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for whoever prefers to keep the venv in the same folder
A placeholder is added until the real functionality is implemented
Apparently, pipenv doesn't escape them properly when parsing TOML and it should have been '\\\\' for one '\', which is ridiculous.
IamMaxim
approved these changes
Mar 7, 2021
illright
approved these changes
Mar 7, 2021
|
There's an issue on Linux, you can find its description here. Seems like it's relatively fresh, so the fix isn't merged into Pyinstaller yet. I'm not sure if Pipenv can handle installing random ZIP files, so I guess we may just have to tell Kruglov to wait (or forget about it, he has Windows anyway) |
|
The issue seems to talk about Arch only. Any info if it is reproduceable on Debian/Ubuntu as well? |
|
Please, our CI is more ignored than anything, don't even bother) I don't know about Ubuntu (though I could pull up a USB stick and live boot, but) perhaps @IamMaxim could try it on his Ubuntu? |
alkaitagi
approved these changes
Mar 8, 2021
kuredoro
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PyInstaller as a dev-dependency for building a bundle to be distributed directly, along with script shortcuts and instructions. Additionally, I disabled the ugly TensorFlow warnings
The unix version needs testing. I only tested on Windows.
If the dist looks too bloated, or we don't want the user to search through the whole folder for the main executable, it is possible to bundle it in a single file, but that doesn't seem to be highly advisable.
I have also not yet tried any optimization flags.