Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cloudflared tag 1.0 -> 2023.7.3 #226

Closed
wants to merge 1 commit into from
Closed

Update Cloudflared tag 1.0 -> 2023.7.3 #226

wants to merge 1 commit into from

Conversation

WisdomSky
Copy link
Contributor

No description provided.

@WisdomSky WisdomSky mentioned this pull request Jul 26, 2023
Closed
@WisdomSky
Copy link
Contributor Author

WisdomSky commented Jul 29, 2023 •
edited
Loading

Hi @tigerinus,

Is there any reason why this is still yet to be merged?
I saw some PRs that came after this but were already merged.

If the concern is regarding the tag becoming 2023.7.3 from 1.0, this is just to streamline the version naming scheme with cloudflared's versioning.
Tag wisdomsky/casaos-cloudflared:1.0 is based on 2023.X.X of cloudflared release or more specifically 2023.6.0 under the hood.

@WisdomSky WisdomSky closed this Jul 29, 2023
@WisdomSky WisdomSky deleted the 07-27-2023 branch July 29, 2023 06:59
@tigerinus
Copy link
Contributor

@WisdomSky

My apologies. I looked at PR days ago and I have no problems with it.

It's just the version change that I figured to leave it to our AppOps team for some internal testing.

@raller1028 did u get a chance to test this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WisdomSky @tigerinus