Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the code that replaces space to + #117

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

prjvvl
Copy link
Contributor

@prjvvl prjvvl commented Apr 28, 2023

While encoding the query/key, replacing space with + was responsible for two main problems

  1. Users were not able to use phrases properly (issues search phrase with quotation #109 and how to remove quotation from input string ? #107).
  2. Users were not able to use additional techniques to refine their searches (issue Searching a query with Google's search techniques #66)

This simple change resolves both issues and works for both search and get_news functions.

@HurinHu HurinHu merged commit 5a6c28f into Iceloof:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants