Use type to reflect the actual type of internal event #162
Assignees
Comments
This was referenced Feb 26, 2024
Closed
oxzi
added a commit
that referenced
this issue
Apr 15, 2024
The "internal" event type was used both for scheduled reevaluations and for initial reevaluations during startup. This type is currently being used at two different points for two distinct topics: scheduled reevaluations and initial reevaluations during startup. This event type was now split into "reevaluation-scheduled" and "reevaluation-startup" to distinct those types. To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
oxzi
added a commit
that referenced
this issue
Apr 15, 2024
The "internal" event type was used both for scheduled reevaluations and for initial reevaluations during startup. This type is currently being used at two different points for two distinct topics: scheduled reevaluations and initial reevaluations during startup. This event type was now split into "reevaluation-scheduled" and "reevaluation-startup" to distinct those types. To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
oxzi
added a commit
that referenced
this issue
Apr 16, 2024
The "internal" event type was used both for scheduled reevaluations due to their age and for initial reevaluations during startup. This type is currently being used at two different points for two distinct topics: age-based reevaluations and initial reevaluations during startup. This event type was now split into "reevaluation-age" and "reevaluation-startup" to distinct those types. To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
oxzi
added a commit
that referenced
this issue
Apr 17, 2024
It was ambiguous what the "internal" event type especially stand for. As currently both of its use cases are some kind of reevaluation - either during the program's startup or due to an event's age -, it was renamed to "reevaluation". To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
oxzi
added a commit
that referenced
this issue
Jun 13, 2024
It was ambiguous what the "internal" event type especially stand for. As currently both of its use cases are some kind of reevaluation - either during the program's startup or due to an event's age -, it was renamed to "incident-age". To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
julianbrost
pushed a commit
that referenced
this issue
Jun 14, 2024
It was ambiguous what the "internal" event type especially stand for. As currently both of its use cases are some kind of reevaluation - either during the program's startup or due to an event's age -, it was renamed to "incident-age". To ensure database-level stability, the column type was changed from text to a custom enum. Closes #162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, internal events use the type name
internalwhich is rather useless for Web.The type should use specific names to indicate what the event is about.
It's currently used in two cases:
There may be more added in the future. We need to make sure that there are no such surprises for Web anymore, @julianbrost suggested to use an enum for
event.typeto ensure that.The text was updated successfully, but these errors were encountered: