-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible ID tags #105
Flexible ID tags #105
Conversation
cf0fcc1
to
3193abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema upgrade script will probably have to be renamed as well before merging the PR. But as far as I can tell, the corresponding changes that will be needed in notifications-web were not started yet, were they? (So I don't want to say it will be the next one and should use 016.sql
yet.)
3193abf
to
4f09268
Compare
Changes look good so far from just looking over the code. I'll continue with testing once a corresponding web PR is ready (so that I don't break my test setup while doing so). |
@yhabteab Can you do me a favor and test this, especially in conjunction with Icinga/icinga-notifications-web#133? Also, in case anyone needs it, I already have a SQL snippet lying around to roll back that schema change: ALTER TABLE object ADD COLUMN host text, ADD COLUMN service text;
UPDATE object SET host = (SELECT value FROM object_id_tag WHERE object_id = id AND tag = 'host');
UPDATE object SET service = (SELECT value FROM object_id_tag WHERE object_id = id AND tag = 'service');
ALTER TABLE object ALTER COLUMN host SET NOT NULL;
DROP TABLE object_id_tag; |
4f09268
to
62b0d67
Compare
56163c6
to
808e216
Compare
Changes requested were done, the Go part looks fine so far but I'm waiting on the PHP part for a final review
1b2ec0e
to
1f660e9
Compare
1f660e9
to
2e421b2
Compare
resolves #85