-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #10081
Draft
Al2Klimov
wants to merge
25
commits into
support/2.14
Choose a base branch
from
doc2143
base: support/2.14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update documentation #10081
+195
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/documentation
End-user or developer help
area/setup
Installation, systemd, sample files
bug
Something isn't working
enhancement
New feature or request
labels
Jun 10, 2024
The installation documentation currently implies that all commands are being prompted by the root user or an user with root-like privileges. This is now explicitly stated and, additionally, another if-guard was added to not include the "Add Icinga Package Repository" section for Windows, as it does not fit there. Closes #9959.
just like on packages.icinga.com and for the same security reasons we don't use apt-key add anymore for: https://blog.cloudflare.com/dont-use-apt-key Our repos already reference https://packages.icinga.com/icinga.key and both RPM distro families properly handle that.
The Backports Repository is required for Debian 9, but we don't build even v10 anymore.
We instruct the users to build as root and chown just /usr/local/icinga2/var, but at least `icinga2 api setup` also needs to modify /usr/local/icinga2/etc.
It's EOL.
feat: Add the `$` character to the escape sequences table.
oxzi
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I guess. I don't know what you want me to review?
This is a good alternative to `icinga2 feature enable debuglog`: * Object creation/deletion via API happens immediately and requires no restart * Hence, the debug log is enabled exactly as long as desired Co-authored-by: alvar <8402811+oxzi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
End-user or developer help
area/setup
Installation, systemd, sample files
bug
Something isn't working
cla/signed
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
Backport of
last_in_downtime
attrs #10050Object{created,deleted,modified}
docs #10071