Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility::ValidateUTF8(): use UTF8-CPP #7014

Merged
merged 29 commits into from
Mar 18, 2019
Merged

Utility::ValidateUTF8(): use UTF8-CPP #7014

merged 29 commits into from
Mar 18, 2019

Conversation

Al2Klimov
Copy link
Member

No description provided.

nemtrif and others added 23 commits August 15, 2015 12:11
@nemtrif
Initial commit
6bb44ed
@nemtrif
Initial import
46d0d80 
Importing utf8 cpp 2.3.4 to GitHub.
@nemtrif
Fixing Readme.md
735b8b7
@nemtrif
Removing various infrastructure files
1cbc187
@nemtrif
Initial CMake files
2620091
@nemtrif
CMake for negative test
f029fcc
@mominul
Syntax Highlighting
4ddacd6
@nemtrif
Merge pull request #2 from mominul/patch-1
b4c761d 
Syntax Highlighting
@ghewgill
Check for end iterator before using iterator
9d52bc1 
If it == end, then sequence_length(it) will be called which will attempt to dereference the it iterator. This is normally harmless, because the get_sequence_x() functions each check to see whether it == end. However, some runtime libraries (MSVC CRT debug build in particular) check the validity of every iterator dereference, and a runtime check will be triggered inside sequence_length() if it is at the end.
@nemtrif
Merge pull request #8 from ghewgill/master
a5ad5ec 
Check for end iterator before using iterator
@nemtrif
Consolidate CMakeLists.txt
67036a0 
The build has only one CMakeLists.txt now.
Added support for CTest
@nemtrif
Fix -Wshadow warnings
5408022 
Fix the GNU and CLang's -Wshadow warning by renaming the input parameters.
@nemtrif
Minor documentation update.
0232ab8
Update test.cpp
17ca704 
This test was failing for me when I compiled with clang. Must have a different initializer.

I changed the test to match the example from the README and it passes when I build with both clang and gcc.
@nemtrif
Merge pull request #11 from willfrey/patch-1
1537543 
Update test.cpp
@amerry
Fix smoke test on MSVC
3723b0c 
The MSVC-generated code in debug mode was (quite rightly) complaining
about iterating past the start of an empty vector, and aborting the
test.
@Erroneous1
Modernize cmake
3866386 
* Able to use as subfolder
* Able to install (and import again in cmake)
* Able to disable tests
* Able to disable samples
@nemtrif
Merge pull request #17 from Erroneous1/modern_cmake
37f382b 
Modernize cmake
@nemtrif
Merge pull request #14 from amerry/msvc-build-fix
e6bde78 
Fix smoke test
cmake: fixed undefined ${CMAKE_INSTALL_LIBDIR}
fd39f7e
@nemtrif
Merge pull request #18 from arteniioleg/patch-1
b641599 
cmake: fixed undefined ${CMAKE_INSTALL_LIBDIR}
@nemtrif
Release v2.3.6
60c490b
@nemtrif
Create .gitignore
0a23881 
Ignore:
- .vscode
- build
@Al2Klimov
Copy link
Member Author

Substitutes #7013.

@Al2Klimov Al2Klimov requested a review from dnsmichi March 14, 2019 10:11
@dnsmichi
Copy link
Contributor

Which license does the library use? I wasn't able to figure it out from the headers.

@Al2Klimov
Copy link
Member Author

https://github.com/Icinga/icinga2/blob/3ec0268cb48dc005f8a7719e007c53ef111035cd/third-party/utf8cpp/source/utf8.h

@Al2Klimov
Copy link
Member Author

Looks like MIT.

@dgoetz
Copy link
Contributor

dgoetz commented Mar 14, 2019

Looks more like https://opensource.org/licenses/BSL-1.0

@lazyfrosch
Copy link
Contributor

Please document the license with name and URL reference inside the third-party/utf8cpp/ directory.

Packagers will thank you.

@Al2Klimov Al2Klimov removed the request for review from dnsmichi March 15, 2019 08:50
@Al2Klimov Al2Klimov self-assigned this Mar 15, 2019
@Al2Klimov
Copy link
Member Author

@lazyfrosch nemtrif/utfcpp#23

@Al2Klimov Al2Klimov mentioned this pull request Mar 15, 2019
Merged
@Al2Klimov Al2Klimov requested review from lazyfrosch and removed request for lazyfrosch March 15, 2019 11:54
@Al2Klimov Al2Klimov removed their assignment Mar 15, 2019
@Al2Klimov Al2Klimov requested review from dnsmichi and removed request for lazyfrosch March 15, 2019 12:35
@dnsmichi
Copy link
Contributor

Thanks for clarification, much appreciated 👍

@dnsmichi dnsmichi added the core/quality Improve code, libraries, algorithms, inline docs label Mar 18, 2019
@dnsmichi dnsmichi added this to the 2.11.0 milestone Mar 18, 2019
@dnsmichi dnsmichi merged commit ea80d93 into master Mar 18, 2019
@Al2Klimov Al2Klimov deleted the feature/utf8cpp branch March 18, 2019 10:12
@lippserd lippserd mentioned this pull request Dec 6, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Al2Klimov @dnsmichi @dgoetz @lazyfrosch @nemtrif @mominul @ghewgill @amerry @Erroneous1