Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite error handling in HttpServerConnection#EnsureValidHeaders() #7486

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Sep 9, 2019

Throwing local exceptions unnecessarily pollutes the exception
stack with immediate unwinding. Avoid this pattern at all cost within
Boost.Coroutines. MSVC may handle exceptions differently and cause
problems with stack unwinding.

refs #7431
refs #7351

Throwing local exceptions unnecessarily pollutes the exception
stack with immediate unwinding. Avoid this pattern at all cost within
Boost.Coroutines. MSVC may handle exceptions differently and cause
problems with stack unwinding.

refs #7431
refs #7351
@dnsmichi dnsmichi added this to the 2.11.0 milestone Sep 9, 2019
@dnsmichi dnsmichi added area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working core/build-fix Follow-up fix, not released yet core/quality Improve code, libraries, algorithms, inline docs labels Sep 9, 2019
@dnsmichi dnsmichi merged commit 6139258 into master Sep 9, 2019
@dnsmichi dnsmichi deleted the bugfix/http-header-error-handling branch September 16, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working core/build-fix Follow-up fix, not released yet core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant