Drop PHP 5.3 support #3213
Drop PHP 5.3 support #3213
Conversation
Al2Klimov
force-pushed
the
feature/drop-php-5-3-support
branch
from
1e347e4
to
7e20dc0
Compare
Al2Klimov
requested review from
Thomas-Gelf and
nilmerg
and removed request for
lippserd
|
Rationale: #3186 (comment) |
|
I agree with you that it is time to drop 5.3. We announced this with 2.5.0, but we failed to enforce it. Changing this in a patch version might break existing setups that didn't listen and still run 2.5.0 or 2.5.1 on 5.3. It's not supported, sure. But it's not a good move to break things in a minor release. When merging this I'd first create a support/2.5 branch like we did in other projects. This would allow us still backport important fixes to a 2.5.2 in a safe and compatible way while moving on with the master. This would however influence the release policy for Icinga Web 2, and it probably also depends on the schedule for 2.6. @lippserd: it's your choice! |
Thomas-Gelf
requested review from
lippserd
and removed request for
Thomas-Gelf and
nilmerg
lippserd
force-pushed
the
feature/drop-php-5-3-support
branch
from
7e20dc0
to
4eef886
Compare
lippserd
force-pushed
the
feature/drop-php-5-3-support
branch
from
4eef886
to
fc1f6e1
Compare
| @@ -568,11 +568,10 @@ public function getRequirements($skipModules = false) | |||
| $set = new RequirementSet(); | |||
|
|
|||
| $set->add(new PhpVersionRequirement(array( | |||
| 'condition' => array('>=', '5.3.2'), | |||
| 'condition' => array('>=', '5.4'), | |||
There was a problem hiding this comment.
@lippserd Aren't we using 5.6 as our new requirement?
There was a problem hiding this comment.
Yes, will be in a new PR. Did not want to mix things here.
No description provided.