Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes made in dashlet views #4755

Draft
wants to merge 106 commits into
base: enhanced-dashboards-development
Choose a base branch
from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Apr 25, 2022

yhabteab and others added 11 commits April 22, 2022 09:26
I'm not yet convinced about this solution. The name
*framework parameter* isn't always correct. (i.e. page)

Then there's also an alternative available by using the
`rel` attribute of anchors with a custom value. If it's
set our JS preserves (or doesn't) the `_dashlet` param.
It cannot do that for every url that's loaded into the
same container. (e.g. stat badges in the footer of lists)
* It's bound to the `Window` object
* If there's a request header, it's set
* If there's a request param, it's set
* It's preserved trough redirects not changing the path
* If no redirect happens, a response header is set
* JS accepts the response header always, maintains a data-attribute
* JS transmits it in a request header, if it's not GET and not changing the path
* Does not signal the change yet
* Does not allow to save the change yet
* Too verbose code still, probably
* Error handling not final
If a view is refreshed, this ensures that the scroll
position doesn't change now.
@nilmerg nilmerg self-assigned this Apr 25, 2022
@cla-bot cla-bot bot added the cla/signed label Apr 25, 2022
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch 4 times, most recently from 2c7449d to 092bbaf Compare May 20, 2022 10:47
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch 4 times, most recently from f29673b to d826647 Compare June 2, 2022 17:14
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch from 010acc9 to f5c8fc9 Compare June 10, 2022 07:12
@raviks789 raviks789 force-pushed the enhanced-dashboards-development branch 2 times, most recently from e362ae6 to faf7709 Compare June 10, 2022 12:14
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch 3 times, most recently from 71bba87 to 9377848 Compare June 14, 2022 08:50
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch from 9377848 to 3ecf705 Compare August 22, 2022 07:35
@yhabteab yhabteab force-pushed the enhanced-dashboards-development branch 2 times, most recently from 2ef9854 to 17752eb Compare July 14, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants