-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyout menu: Render menu bottom-up
if it exceeds the viewport height
#5037
Conversation
bottom-up
if it exceeds the viewport heightbottom-up
if it exceeds the viewport height
99f6765
to
a18d03a
Compare
a18d03a
to
cebfb8d
Compare
cebfb8d
to
4c965bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically it works.
I found a problem, though, which can best be seen on this screenshot:
in extreme conditions this could fire back and now exceed the top
Since the items outside of the screen aren't accessible anymore in this case, this should be prevented by restricting the height and make the flyout scrollable.
I made a quick mockup for this.
While the screenshot shows the collapsed version, this problem also occurs in the expanded version of the sidebar.
Another thing, that I discovered, was that the padding doesn't adapt (properly), when switching to the collapsed state. This way the last item in the scrollable part is covered by the fixed part of the menu. This is probably a different topic.
8f26423
to
2e41d1e
Compare
Hi @flourish86, I have discussed the problem of overflow with Johannes. It shouldn't happen in a normal screen size, and it's a different issue anyway. So for this PR we will leave it as it is. |
2e41d1e
to
ead1123
Compare
ead1123
to
f3b20a8
Compare
fixes #4594