Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winter.less: Don't set bg-color to transparent #5038

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Winter.less: Don't set bg-color to transparent #5038

merged 1 commit into from
Jun 19, 2023

Conversation

sukhwinder33445
Copy link
Contributor

fixes #4708

@sukhwinder33445 sukhwinder33445 added bug Something isn't working area/ui Affects the user interface labels Jun 12, 2023
@sukhwinder33445 sukhwinder33445 self-assigned this Jun 12, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 12, 2023
flourish86
flourish86 requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line is fine.

Please set @menu-2ndlvl-highlight-bg-color to fade(@icinga-blue, 10); in base.less

so that the hover effect is better visible

Artboard

@sukhwinder33445 sukhwinder33445 mentioned this pull request Jun 14, 2023
Merged
@nilmerg nilmerg merged commit 65b9024 into master Jun 19, 2023
@nilmerg nilmerg deleted the fix/winter-theme-menu-hover branch June 19, 2023 08:09
@nilmerg nilmerg added this to the 2.12.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@flourish86 flourish86 Awaiting requested review from flourish86

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/ui Affects the user interface bug Something isn't working cla/signed
Projects
No open projects
Icinga Web 2.12
Status: Done
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Winter theme: Sidebar menu hover have no effect
3 participants
@sukhwinder33445 @flourish86 @nilmerg