Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PostgreSQL grants #5130

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix PostgreSQL grants #5130

merged 4 commits into from
Oct 27, 2023

Conversation

yhabteab
Copy link
Member

fixes #5129

@cla-bot cla-bot bot added the cla/signed label Sep 28, 2023
@yhabteab yhabteab self-assigned this Sep 28, 2023
@yhabteab yhabteab added bug Something isn't working area/installation Affects the installation and removed cla/signed labels Sep 28, 2023
@yhabteab yhabteab added this to the 2.12.1 milestone Sep 28, 2023
@cla-bot cla-bot bot added the cla/signed label Sep 28, 2023
@yhabteab yhabteab force-pushed the fix-wizard-pgsql-grants branch 2 times, most recently from e8c7114 to 638501b Compare September 28, 2023 08:52
@yhabteab yhabteab force-pushed the fix-wizard-pgsql-grants branch 3 times, most recently from e19cd82 to 77c1612 Compare September 28, 2023 11:14
nilmerg
nilmerg requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test this

library/Icinga/Application/MigrationManager.php Outdated Show resolved Hide resolved
library/Icinga/Application/MigrationManager.php Show resolved Hide resolved
modules/setup/application/forms/DbResourcePage.php Show resolved Hide resolved
nilmerg
nilmerg approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@yhabteab
Add missing pgsql USAGE privilege
a99f685
@yhabteab
DbTool: Enhance issuing and verifying pgsql privileges
329fd9e
@yhabteab
MigrationManager: Enhance how pgsql privileges are checked
bcdad8c 
For mysql it's just enough to check whether the privileges are granted
at database or table label, but for PostgreSQL it's necessary that the
privileges are granted at database and at table level.
@yhabteab
DbResourcePage: Don't fail validation if connecting to pgsql wasn't s…
ae9575e 
…uccessfull
@nilmerg nilmerg merged commit 2fb36c0 into main Oct 27, 2023
13 checks passed
@nilmerg nilmerg deleted the fix-wizard-pgsql-grants branch October 27, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@yhabteab yhabteab

Labels
area/installation Affects the installation bug Something isn't working cla/signed
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

UI database migration not fully compatible with PostgreSQL
2 participants
@yhabteab @nilmerg