FormElement: Add RadioElement

[sukhwinder33445]

Blocked by

• Add DeferredInArrayValidator ipl-validator#12

[lippserd]

In addition to the requested changes please

• use heredoc for the expected HTML and
• replace validation with something like an InArray validator provided in addDefaultValidators().

[sukhwinder33445]

• replace validation with something like an InArray validator provided in addDefaultValidators().

This will not help much, since we also need to check for the disabled attribute. And all this should be done before parent::validate() is called. 🤔

[lippserd]

• replace validation with something like an InArray validator provided in addDefaultValidators().

This will not help much, since we also need to check for the disabled attribute. And all this should be done before parent::validate() is called. 🤔

The value should be validated against a list of possible values. Possible values are all options that are not disabled.

[lippserd]

Please don't resolve conversations just for fun. I don't see anything resolved in the code.

[lippserd]

It should be InArrayValidator and not InArray, right?

I think it is best to have an option to defer which values to validate against in the InArrayValidator, by passing a callback to retrieve the possible values.

[lippserd]

It should be InArrayValidator and not InArray, right?

I think it is best to have an option to defer which values to validate against in the InArrayValidator, by passing a callback to retrieve the possible values.

Maybe DeferredInArrayValidator.

[nilmerg]

Missing tests:

• testSetOptionsResetsOptions()
• testOrderOfOptionsAndDisabledOptionsDoesNotMatter()
• testGetOptionReturnsPreviouslySetOption()

•   public function testNullAndTheEmptyStringAreAlsoEquallyHandledWhileDisablingOptions()
    {
        $radio = new RadioElement('radio');
        $radio->setOptions([null => 'Foo', 'bar' => 'Bar']);
        $radio->setDisabledOptions([null]);
  
        $this->assertTrue($radio->getOption(null)->isDisabled());
  
        $radio = new RadioElement('radio');
        $radio->setOptions(['' => 'Foo', 'bar' => 'Bar']);
        $radio->setDisabledOptions(['']);
  
        $this->assertTrue($radio->getOption('')->isDisabled());
  
        $radio = new RadioElement('radio');
        $radio->setOptions([null => 'Foo', 'bar' => 'Bar']);
        $radio->setDisabledOptions(['']);
  
        $this->assertTrue($radio->getOption(null)->isDisabled());
        $radio = new RadioElement('radio');
        $radio->setOptions(['' => 'Foo', 'bar' => 'Bar']);
        $radio->setDisabledOptions([null]);
  
        $this->assertTrue($radio->getOption('')->isDisabled());
    }

•   public function testGetOptionGetValueAndElementGetValueHandleNullAndTheEmptyStringEqually()
    {
        $radio = new RadioElement('radio');
        $radio->setOptions(['' => 'Foo']);
        $radio->setValue('');
  
        $this->assertNull($radio->getValue());
        $this->assertNull($radio->getOption('')->getValue());
  
        $radio = new RadioElement('radio');
        $radio->setOptions([null => 'Foo']);
  
        $this->assertNull($radio->getValue());
        $this->assertNull($radio->getOption(null)->getValue());
    }

[yhabteab]

Please add an option to render the input fields without wrapping them into the radio-label.

[sukhwinder33445]

Please add an option to render the input fields without wrapping them into the radio-label.

Can you explain the use case please?

[yhabteab]

I have a very special use case though that would stretch the scope to explain here but in short, I don't want the inputs to be wrapped in a label that I can neither access it with getWrapper() nor override it.

outdated