Add paging functionality to ResultSet #136
Conversation
…d provides the current page if asked
…' into feature/add-paging-to-result-set # Conflicts: # src/ResultSet.php
There was a problem hiding this comment.
- Please drop all changes to existing parameter and return types, which would break bc
- If you add a missing docstring, document everything not just a few things (short description, params, return type, throws, etc)
- The short description of docstrings must be phrased as instruction, not as description (i.e. "Set" instead of "Sets" and "Return" instead of "Returns")
- Format multiline docstrings this way:
/** * Short description * * [Long description] * * @param declarations * * @return declaration * * @throws declaration */
…et paging, fixed PHPStan configuration, rebuilt baseline, refactored return type annotation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@ncosta-ic @nilmerg What's the motivation for this PR, i.e. when and how would I use it? Regarding the PHPDocs: Please don't use @see protected property for public methods. |
It's part of an attempt to move Icinga DB Web's and Notification Web's
Why? |
If I had to guess: Because public methods (and thus their documentation) could be used outside of the extended class, which would then reference protected properties that could not be accesses in that scope |
…red ResultSet class, reverted PHPStan configuration
Adds basic paging functionality to the ResultSet.
A page size can be set with
setPageSize(n)and the current page (during iteration) can be retrieved withgetCurrentPage().