Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any non-breaking cordova-plugin-add-swift-support version #26

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

BorntraegerMarc
Copy link
Contributor

Configured dependency according to more flexible semver

Configured dependency according to more flexible semver
@BorntraegerMarc
Copy link
Contributor Author

BorntraegerMarc commented Jan 14, 2020

Had to create this PR because now compatibility with other cordova plugins are broken. E.g. https://github.com/NiklasMerz/cordova-plugin-fingerprint-aio/blob/master/package.json#L34 specifies a higher version which can't be installed because the version in this cordova plugin is fixed.

Also I'd appreciate if you could release a new version with this change so I can install it :)

@BorntraegerMarc
Copy link
Contributor Author

Friendly ping to @pandiarajan-i2i can this PR be merged? :)

@praveenraji2i praveenraji2i merged commit 93f1bb5 into Ideas2IT:master Jan 28, 2020
@BorntraegerMarc BorntraegerMarc deleted the patch-1 branch January 28, 2020 07:00
@BorntraegerMarc
Copy link
Contributor Author

Thanks for merging @praveenraji2i ! You mind releasing a new version in the plugin so I can use the new changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants