Add methods to set clock state/rate. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
changed the title
reitermarkus
force-pushed
the
clock-rate
branch
2 times, most recently
from
5f63028
to
6fa5bfa
Compare
|
@legokichi, can you take a look here? Thanks. |
|
@eldesh how about this |
|
@legokichi, @eldesh, any update on this? |
|
@reitermarkus Thank you for your contribution. To ensure symmetry and consistency in the API, could you please add get_clock_state to complement set_clock_state, and get_clock_rate to complement set_clock_rate? |
reitermarkus
force-pushed
the
clock-rate
branch
from
6fa5bfa
to
5004e15
Compare
reitermarkus
force-pushed
the
clock-rate
branch
from
5004e15
to
47b56aa
Compare
|
@eldesh, done. |
|
@reitermarkus looks good 👍 |
|
@eldesh, thanks for merging. Can you please also release a new version with this included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.