Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMLInternalResponse for saml backend #95

Merged
merged 1 commit into from
May 30, 2017
Merged

SAMLInternalResponse for saml backend #95

merged 1 commit into from
May 30, 2017

Conversation

skoranda
Copy link
Contributor

Adds a SAMLInternalResponse class that the saml backend returns instead
of the parent class InternalResponse. The new class allows SAML specific
details to be added into the response that is later passed into
plugins/microservices. The first SAML specific detail added is the SAML
NameID if it is asserted by the IdP that sent the response.

Adds a SAMLInternalResponse class that the saml backend returns instead
of the parent class InternalResponse. The new class allows SAML specific
details to be added into the response that is later passed into
plugins/microservices. The first SAML specific detail added is the SAML
NameID if it is asserted by the IdP that sent the response.
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to handle the NameID in incoming SAML Responses, and this is a neat way to do so.

We have agreed that all commits to the SATOSA repo must be signed but I wouldn't consider this a blocker for now.

@leifj
Copy link
Contributor

leifj commented May 29, 2017

I say merge

@johanlundberg johanlundberg merged commit 085a547 into IdentityPython:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants