Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Use non-case sensitive string for any keys in persisted grants #3184

Closed
brockallen opened this issue Apr 11, 2019 · 6 comments
Closed

Use non-case sensitive string for any keys in persisted grants #3184

brockallen opened this issue Apr 11, 2019 · 6 comments
Assignees

Comments

@brockallen
Copy link
Member

If key is stored in non-case sensitive DB then might be collisions.

@brockallen brockallen self-assigned this Apr 11, 2019
@brockallen brockallen added this to the 3.0 milestone Apr 11, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 10, 2020
@stale stale bot removed the wontfix label Jan 10, 2020
@brockallen brockallen removed this from the 4.0 milestone Mar 24, 2020
@brockallen
Copy link
Member Author

From what I can tell, this is already being done since we use CryptoRandom.CreateUniqueId which in turns uses ByteArrayToString which emits the hex encoded values of the bytes (which of course is not case sensitive).

@brockallen
Copy link
Member Author

Ok, I was wrong... CryptoRandom.CreateUniqueId defaults to base64url encoding. We need to change it everywhere to pass CryptoRandom.CreateUniqueId(format: CryptoRandom.OutputFormat.Hex).

@brockallen brockallen reopened this Mar 25, 2020
@brockallen brockallen added this to the 4.0 milestone Mar 25, 2020
@leastprivilege
Copy link
Member

Yes - we also should make sure we use the handle generation service everywhere?

@brockallen
Copy link
Member Author

PR submitted

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants