Fixing issues I had when trying to build on Windows #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIN_OUTPUT_DIRECTORY
change is because some thing were ending up inbuild/bin
and some things were ending up inbuild/bin/Release
, but they all need to be in the same directory. This ensures that the VS Code generator doesn't get creative with adding/Release
on the end of things.OUTFILE_DIR
for the Python SWIG target is just because it was weird seeingacacia_ia2PYTHON_wrap.cxx
end up inbuild/bin
- I came across that while trying to fix the above actual problemcmake copy
command out into its own step is because it wasn't running when it was part of theacacia_ia2.node
custom command, and I couldn't figure out why, but this worked.binding.gyp.in
is a temporary fix for a related problem -iaccessible2.lib
ends up inbuild/third_party/ia2/lib/Release
for a Release build, because Visual Studio just tacksRelease
on the end. Obviously this fix won't work for a Debug build, but we're assumingRelease
elsewhere already, so we can fix them all at the same time whenever we fix Add a Debug build configuration #178.