Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clone/checkout the code #524

Closed
etna opened this issue Feb 3, 2019 · 4 comments
Closed

Properly clone/checkout the code #524

etna opened this issue Feb 3, 2019 · 4 comments

Comments

@etna
Copy link

etna commented Feb 3, 2019

Hi, may I know how should one checkout the repo properly? There are no instructions on how this should be done; the only instructions on the README are for building.

i did a git clone of this repo but gclient runhooks always fails with 'gclient not configured'. Trying the steps listed in #301 (comment) allows for gclient runhooks to run, but only results in more problems about missing libraries during the build.

Specifically, I notice that following the upstream instructions results in a copy of Debian Sid being pulled to build/linux, but this does not happen in my clone of this repo. I suspect this is where my issues with missing libraries are originating from.

@etna etna changed the title clone Properly clone/checkout the code Feb 3, 2019
@msisov
Copy link
Member

msisov commented Feb 3, 2019

Right, the instructions are missing.

You need to checkout upstream first and add remote to this repo. Then switch to it and gclient will be able to fetch needed dependencies.

@msisov
Copy link
Member

msisov commented Feb 3, 2019

If you have more questions, feel free to reopen

@msisov msisov closed this as completed Feb 3, 2019
@etna
Copy link
Author

etna commented Feb 4, 2019

@msisov
Sorry, I still need help (and a little hand holding here).

As per the upstream instructions, I use depot_tools to perform fetch --nohooks chromium
The next step immediately after that is to run the dependencies script, which I omit because it's only useful for Ubuntu and Debian, following by gcllient runhooks.

I'm certain your add remote to this repo' step comes before gclient runhooks, but I still have no idea how this is done.

@msisov msisov reopened this Feb 4, 2019
@msisov
Copy link
Member

msisov commented Feb 4, 2019

mkdir chromium
fetch --nohooks chromium
git remote add igalia https://github.com/Igalia/chromium
git fetch igalia
git checkout -b ozone-wayland-dev
git reset --hard igalia/ozone-wayland-dev
git pull igalia ozone-wayland-dev
gclient sync

@msisov msisov closed this as completed Feb 4, 2019
msisov pushed a commit that referenced this issue Mar 14, 2019
The browser includes cookie headers in those it sends to the renderer if
DevTools is open. Add a check that the renderer has access to cookie
data for that origin.

This CL only changes the non-network-service codepath. The network
service code path will changed in a followup CL.

BUG=924972
TBR=ricea@chromium.org

(cherry picked from commit 38df166)

Change-Id: Iaa9cd66ab805fa59a61b9f4ae192b4ef94c79962
Reviewed-on: https://chromium-review.googlesource.com/c/1439461
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#629154}
Reviewed-on: https://chromium-review.googlesource.com/c/1478573
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#524}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants