Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template tasks may delete new tasks #293

Closed
jaragunde opened this issue Sep 5, 2016 · 2 comments
Closed

Template tasks may delete new tasks #293

jaragunde opened this issue Sep 5, 2016 · 2 comments

Comments

@jaragunde
Copy link
Member

I've just found a problem in the implementation of #247, in particular this part:

b) delete the empty task when copying tasks from other days or creating the first task from a template.

Steps to reproduce:

  1. Open a new, empty day.
  2. Fill the empty task with some init/end time, project, etc.
  3. Now click on a template button to add a second task.

Expected result: the template task is added, so there are two tasks now.
Actual result: the template task deletes the existing task, even when it's not empty any more.

@tonythomas01
Copy link
Collaborator

Yeah. I see that, the problem being - isDirty is true until the task is automatically or manually saved :( Let me see how this thing can be fixed!

@jaragunde
Copy link
Member Author

commit 29e66f537a08ff034319202fa1d2ab33a82c8eb0
Author: Tony Thomas <01tonythomas@gmail.com>
Date:   Tue Sep 6 11:33:53 2016 +0530

    [#293] Fix: Template tasks may delete new tasks

tonythomas01 added a commit to tonythomas01/phpreport that referenced this issue Sep 7, 2016
tonythomas01 added a commit to tonythomas01/phpreport that referenced this issue Sep 7, 2016
tonythomas01 added a commit to tonythomas01/phpreport that referenced this issue Sep 7, 2016
tonythomas01 added a commit to tonythomas01/phpreport that referenced this issue Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants