Improve locked date management in task updates #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only checking the new task date in a task update operation, instead of also checking the saved date. As a result, it was possible to move a task from a locked date to an unlocked one, and then update any other field. As a side effect, we break the assumption in PartialUpdateTasksAction that every DirtyTask contains a date, which helps fixing #491.
Ensure that date field is extracted from the saved task in case the DirtyTaskVO does not contain it. Also use array_key_first() to get the first task in the list, because a list of tasks where some were discarded might not start with 0. PHP version in the requirements has been bumped to 7.3.0 due to this.
jaragunde
force-pushed
the
i491-enforce-locked-dates
branch
from
967f726
to
7c84020
Compare
This was referenced Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487 and #491.