Add React frontend with authentication #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this wasn't merged yet, I would take the opportunity to squash the refactor commit with the first commit that you introduce the React app. Maybe changing the order will make it a bit easier to rebase:
Also adding a better message in the squash commit that describes better what it does, like the description of this pull request. |
anarute
reviewed
Jul 20, 2023
config/permissions.php
Outdated
| '/services/getProjectUserCustomerReportJsonService.php', | ||
| //user details report: check any user | ||
| '/viewUserDetails.php', | ||
| '/services/getUserProjectCustomerReportJsonService.php' | ||
| ) | ||
| ); | ||
| ); |
There was a problem hiding this comment.
Can we have a commit just for the code styling changes? To avoid mixing it with the real changes.
There was a problem hiding this comment.
I'm backing out any formatting changes for the moment, as they are distracting and not really necessary
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <!-- <link rel="icon" type="image/svg+xml" href="/vite.svg" /> --> |
There was a problem hiding this comment.
Suggested change
| <!-- <link rel="icon" type="image/svg+xml" href="/vite.svg" /> --> |
These changes add a React frontend that will be the start of new pages in the application. OIDC authentication has been added as a context in the React app so that the app will have the user/token information everywhere - this makes it fairly straightforward to hit the new Python API with a bearer token.
anarute
approved these changes
Jul 20, 2023
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a React frontend that will be the start of new pages in the application. OIDC authentication has been added as a context in the React app so that the app will have the user/token information everywhere - this makes it fairly straightforward to hit the new Python API with a bearer token. The existing php login manager was also changed in order to handle OIDC authentication.
Example pages have been set up - both in the React app and the php app - showing how to use the token from the OIDC in an Authorization header as a bearer token. On the php side, it is
fastapiTest.phpand on the React side, it isDedications.jsx.