Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in "query" tests #904

Open
wingo opened this issue Aug 16, 2017 · 1 comment
Open

Race condition in "query" tests #904

wingo opened this issue Aug 16, 2017 · 1 comment

Comments

@wingo
Copy link

wingo commented Aug 16, 2017

For horrible reasons, Snabb counters have two lives: an existence that's local to the process, on the Lua heap, and an external copy that's in shared memory. Snabb will periodically "commit" the private counter values to the public locations. This means there can be a delay between a counter being updated privately and the new value being publically visible. This is a race condition that can cause tests to fail, if they assume that they can perform some sequence of actions and then use snabb lwaftr query or snabb config get-state to read counter values. We should fix this somehow!

wingo added a commit that referenced this issue Aug 16, 2017
wingo added a commit to snabbco/snabb that referenced this issue Aug 16, 2017
@dpino
Copy link
Member

dpino commented Jun 19, 2018

Perhaps unrelated but worth mentioning there was a race condition, due to missing a signal when parent process died, that affected query and other subcommands. Fixed in #1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants