Report RX/TX stats per queue on interface view #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takikawa
reviewed
Jul 3, 2018
There was a problem hiding this comment.
One issue that I see with this approach: I don't think the pre-queue stats will be the same as global stats actually. Because you can have one process with multiple NIC apps that use different queues and different counters. No single counter will reflect the global stats, but rxcounter may still be set in that case.
|
Superseded by #1148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134.
When the lwAFTR is run with RSS only the master process updates the stats, except for per-queue stats which are updated per process. What happened in issue 1134 is that one of processes was showing RX/TX values as 0. The reason was that this was the non-master process and its counters are never updated. Instead of showing global rx/tx counters processes should show their per-queue stats in interface view.
If there's only one process I think its per-queue stats are equals to global rx/tx stats.