Fix several issues related to seek bar for VR video playing #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is creating some race conditions and cause the seek to fail sometimes. And there's no reason to pause in this case as well. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
We should also considering the padding after we got the seekBar view bound Signed-off-by: Songlin Jiang <sjiang@igalia.com>
svillar
reviewed
Sep 27, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/MediaControlsWidget.java
Show resolved
Hide resolved
svillar
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is creating some race conditions and cause the seek to fail sometimes.
And there's no reason to pause in this case as well.
We should also considering the padding after we got the seekBar view bound
Before:
com.igalia.wolvic-20230927-181322.mp4
After:
com.igalia.wolvic-20230927-181529.mp4