Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisionGlass] Use the largest window distance by default #1241

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

svillar
Copy link
Member

@svillar svillar commented Feb 6, 2024

Due to the constraints and FoV of the VisionGlass users cannot see the whole browser window by default because it's too close. We're modifying the settings so that the default window distance is the larger available.

The whole window is not entirely visible though but it's the best we can do ATM.

Due to the constraints and FoV of the VisionGlass users cannot see
the whole browser window by default because it's too close. We're
modifying the settings so that the default window distance is the
larger available.

The whole window is not entirely visible though but it's the best
we can do ATM.
Copy link
Collaborator

@felipeerias felipeerias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It makes sense to set this by default.

We can move the window even further if needed by changing the value of R.dimen.window_world_z_max.

Perhaps we also need to change the default window size?

@svillar
Copy link
Member Author

svillar commented Feb 7, 2024

LGTM. It makes sense to set this by default.

We can move the window even further if needed by changing the value of R.dimen.window_world_z_max.

I recall you mentioned you couldn't move it too far away, not sure what's a good limit

@svillar svillar merged commit 3bf1866 into main Feb 7, 2024
20 checks passed
@svillar svillar deleted the vg_window_distance branch February 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants