Clean-up of resizing logic #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
force-pushed
the
felipeerias/resizing-adjustments
branch
from
d2b96ba
to
557ec54
Compare
felipeerias
force-pushed
the
felipeerias/resizing-adjustments
branch
2 times, most recently
from
4fb402d
to
b67fd2d
Compare
felipeerias
changed the title
felipeerias
force-pushed
the
felipeerias/resizing-adjustments
branch
from
b67fd2d
to
098cc5e
Compare
svillar
requested changes
May 2, 2024
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
Clean-up of our resizing logic to make it more consistent and to remove some edge cases. This logic is now mostly encapsulated inside of WindowWidget. Manual mode allows the window to be resized freely within the allowed boundaries. The maximum width depends on the number of active windows. The maximum height has been increased slightly to accommodate vertical videos better. WindowWidget.getSizeForScale() is used to resize the window when using one of the preset sizes and when entering fullscreen. It will keep the window size within the boundaries while trying to preserve the current aspect ratio.
felipeerias
force-pushed
the
felipeerias/resizing-adjustments
branch
from
098cc5e
to
ce348b2
Compare
|
@svillar Thank you, I have applied your suggestions and rebased the branch. It is ready for review again. |
svillar
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up of our resizing logic to make it more consistent and to remove some edge cases. This logic is now mostly encapsulated inside of
WindowWidget.Manual mode allows the window to be resized freely within the allowed boundaries. The maximum width depends on the number of active windows. The maximum height has been increased slightly to accommodate vertical videos better.
WindowWidget.getSizeForScale()is used to resize the window when using one of the preset sizes and when entering fullscreen. It will keep the window size within the boundaries while trying to preserve the current aspect ratio.