[Vision Glass] China app name and id #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft for now, while the other Vision Glass PR are reviewed. |
felipeerias
force-pushed
the
felipeerias/vg-appid
branch
from
22cf6e8
to
302d1bd
Compare
felipeerias
changed the title
felipeerias
force-pushed
the
felipeerias/vg-appid
branch
from
302d1bd
to
24aa1f9
Compare
svillar
requested changes
Jun 19, 2024
|
Also I don't understand what you need to specify the id when that's the default one |
Set the app name of the Vision Glass variant to "Wolvic Vision" and the application id for China to "com.igalia.wolvic.visionglass".
felipeerias
force-pushed
the
felipeerias/vg-appid
branch
from
24aa1f9
to
b6fc53a
Compare
felipeerias
changed the title
svillar
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the app name of the Vision Glass variant to "Wolvic Vision" and the application id for China to "com.igalia.wolvic.visionglass".