Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo is not showing items visually correct #2174

Closed
Volen99 opened this issue Jan 31, 2022 · 2 comments · Fixed by #2201
Closed

Combo is not showing items visually correct #2174

Volen99 opened this issue Jan 31, 2022 · 2 comments · Fixed by #2201

Comments

@Volen99
Copy link
Contributor

Volen99 commented Jan 31, 2022

Description

Combo items are not displayed visually correct.

  • ignite-ui version:
  • browser:

Steps to reproduce

  1. Go to this JsFiddle
  2. Open the Combo and observe

Result

image

Expected result

image

@hanastasov
Copy link
Contributor

Possibly related to #2154

@hanastasov
Copy link
Contributor

@Volen99 found that the fix for #2119 and #2124 is the reason why items are cut off. This PR reverts this fix, but this leads to #2119 again.

Summary of our investigation:

  1. igCombo - Duplicate items are displayed if dataSource contains both half-width and full-width characters and virtualization is enabled. #2124 is reproducible in 20.1, but is not reproducible in 22.1, even without the "fix", so let's ignore this issue for now.
  2. Don't remove the fix for igCombo - visibleItemsCount does not work properly if dataSource contains both half-width and full-width characters. #2119 . Instead, set height using custom css. See if visibleItemsCount works properly. If not, investigate if setting the height is the reason for this, or something else in the code.
  3. If setting a height breaks the visibleItemsCount, then just removes this fix, and will suggest a custom work around for igCombo - visibleItemsCount does not work properly if dataSource contains both half-width and full-width characters. #2119
  4. In the end, retest all bugs - Combo is not showing items visually correct #2174, igCombo - visibleItemsCount does not work properly if dataSource contains both half-width and full-width characters. #2119 and igCombo - Duplicate items are displayed if dataSource contains both half-width and full-width characters and virtualization is enabled. #2124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants