Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCurrentResourceStrings contains a breaking change in 17.0.x #13656

Closed
ChronosSF opened this issue Nov 8, 2023 · 0 comments · Fixed by #13658
Closed

getCurrentResourceStrings contains a breaking change in 17.0.x #13656

ChronosSF opened this issue Nov 8, 2023 · 0 comments · Fixed by #13658

Comments

@ChronosSF
Copy link
Member

ChronosSF commented Nov 8, 2023

Description

IgniteUI/igniteui-angular-samples#3402 this PR is with migrations executed.

The getCurrentResourceStrings function that is used in two localization samples has a breaking change, requiring the user to pass a param and the build fails.

We should either add a migration for this, add it in the migration guide or make the parameter optional, if possible.

(the change is also missing from the changelog)

  • igniteui-angular version: 17.0.0-beta.0
  • browser: n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants