Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to select columns instead of hide columns #6858

Closed
GibletJr opened this issue Mar 3, 2020 · 4 comments · Fixed by #8158
Closed

Option to select columns instead of hide columns #6858

GibletJr opened this issue Mar 3, 2020 · 4 comments · Fixed by #8158
Assignees
@StefanIvanov @zdrawku @rkaraivanov @radomirchev
Labels
grid: column-hiding 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
08-Sep-20 M13 Sprint 3 21-Sep-20 M13 Sprint 4 ROADMAP 2020 5-Oct-20 M13 Sprint 5 19-Oct-20 M13 Release Sprint 02-Nov-20 M14 Sprint 1

Comments

@GibletJr
Copy link

GibletJr commented Mar 3, 2020

To allow a user to control what columns appear in the igx-grid, the columnHiding property must be set to true which presents the default IgxColumnHidingComponent. Our Engineering team is receiving multiple reports that requiring to check which columns to hide is the complete opposite of the Excel Style Filtering dialog which requires the user to check which data they want to see (attached screenshots).

I have reported the above confusing (and contradicting) UX in Support Ticket CAS-206171-T2N7N1.

We would like to see the option of reversing the current UX to select which columns to display; not hide. In the response to the above support ticket, a workaround was provided that does work but solely relies on overriding the default behavior by pulling elements by class names. This type of implementation has proven to be highly brittle and prone to breaking in subsequent releases as the IGX developers don't have an expectation that custom logic has been implemented using CSS class names.

image
@ericmahlberg
Copy link

+1. Agree it would be nice to have this reversed (or at least configurable)

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 20, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label May 27, 2020
@Lipata Lipata reopened this May 27, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 15, 2020
@DiyanDimitrov DiyanDimitrov removed the status: inactive Used to stale issues and pull requests label Aug 24, 2020
@DiyanDimitrov DiyanDimitrov reopened this Aug 24, 2020
@kdinev kdinev mentioned this issue Sep 14, 2020
Closed
@StefanIvanov StefanIvanov self-assigned this Sep 21, 2020
@radomirchev radomirchev added this to Milestone 13 (Due by Oct, 19, 2020) in ROADMAP 2020 Sep 24, 2020
@rkaraivanov rkaraivanov added the 🛠️ status: in-development Issues and PRs with active development on them label Sep 28, 2020
rkaraivanov added a commit that referenced this issue Sep 28, 2020
@rkaraivanov
fix(grid): Deselect columns for hiding
487a8d1 
Change the interaction for column hiding UI.
Updated tests.

Closes #6858
@rkaraivanov rkaraivanov mentioned this issue Sep 28, 2020
Merged
14 tasks
@radomirchev radomirchev moved this from To Do to Development in 21-Sep-20 M13 Sprint 4 Sep 30, 2020
@zdrawku zdrawku removed the 🛠️ status: in-development Issues and PRs with active development on them label Oct 6, 2020
@zdrawku zdrawku added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Oct 6, 2020
@radomirchev radomirchev added this to Validation in 5-Oct-20 M13 Sprint 5 Oct 16, 2020
@radomirchev radomirchev moved this from Milestone 13 (Due by Oct, 19, 2020) to Milestone 14 (Nov DD, 2020) in ROADMAP 2020 Oct 27, 2020
@radomirchev radomirchev added this to Validation in 02-Nov-20 M14 Sprint 1 Nov 2, 2020
zdrawku added a commit that referenced this issue Nov 6, 2020
@rkaraivanov @SisIvanova
@zdrawku @ChronosSF
Toolbar refactor (#8158)
c267b3c 
* feat(grid-toolbar): Toolbar refactor

Closes #8055

* feat(grid-toolbar): Hierarchical grid implementation

Closes #8055

* refactor(grid-toolbar): Correctly grid context
through templates in hierarchical grid

* fix(grid): Deselect columns for hiding

Change the interaction for column hiding UI.
Updated tests.

Closes #6858

* feat(grid): Emit when the grid is fully available in the DOM

Closes #7924

* refactor(toolbar): Hierachical grid tweaks.
Toolbar actions are rendered once the grid is 'fully' loaded in order to
prevent expression changed after checked errors caused by
updating the column collection.
More unit tests updates.

* chore(*): Dev demos updates

* refactor(toolbar): Toolbar unit tests

* refactor(tests): More unit tests

* refactor(toolbar): Tests, api docs and tweaks

* style(toolbar): provide styling for grid toolbar component

* refactor(*): Unit tests

* refactor(*): More unit tests

* chore(styling): run stylelint --fix

* refactor(toolbar): Even more unit tests

* style(toolbar): update elevations, border & title width

* update dropdowns border

* refactor(toolbar): remove unnecessary selectors

* refactor(toolbar): change elevation variable

* docs(toolbar): remove unnecessary requires from sass docs

* feat(grid-toolbar): Add basic migrations

* feat(toolbar): Clean up migrations
Migrate the toolbar based on the old input prop value

* fix(migrations): File changes ordering

* feat(toolbar): Template directive migration

* fix(toolbar): Focus action comp input on open
Remove filtering overlay keydown `catch'em all` handler.

* feat(toolbar): Hierarchical grid migrations

* fix(toolbar): Migration binding on empty directives

* feat(toolbar): Migrate template context bindings

* fix(toolbar): Backward compatible props

* chore(toolbar): Unit tests tweaks

* fix(toolbar): Toolbar width growing with pinned area

* fix(toolbar): Expression changed error

* fix(toolbar): Dropdown max height

* fix(toolbar): Skip excel export dropdown

* fix(toolbar): Choppy toggling of toolbar elements

* refactor(toolbar): Address review comments

Co-authored-by: Silvia Ivanova <SIvanova@infragistics.com>
Co-authored-by: Zdravko Kolev <zkolev@infragistics.com>
Co-authored-by: Stamen Stoychev <sstoychev@infragistics.com>
@radomirchev
Copy link
Contributor

@GibletJr , the feature is to be available with the release of Ignite UI 11.0.0

@radomirchev radomirchev moved this from Validation to Done in 02-Nov-20 M14 Sprint 1 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanIvanov StefanIvanov

@zdrawku zdrawku

@rkaraivanov rkaraivanov

@radomirchev radomirchev

Labels
grid: column-hiding 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
ROADMAP 2020
Milestone 14 (Nov DD, 2020)
02-Nov-20 M14 Sprint 1
  
Done
08-Sep-20 M13 Sprint 3
  
To Do
19-Oct-20 M13 Release Sprint
  
Validation
21-Sep-20 M13 Sprint 4
  
Development
5-Oct-20 M13 Sprint 5
  
Validation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toolbar refactor IgniteUI/igniteui-angular
10 participants
@kdinev @StefanIvanov @ChronosSF @Lipata @ericmahlberg @zdrawku @rkaraivanov @DiyanDimitrov @radomirchev @GibletJr