Toolbar refactor #8158
Merged
Toolbar refactor #8158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
through templates in hierarchical grid
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
Change the interaction for column hiding UI. Updated tests. Closes #6858
Toolbar actions are rendered once the grid is 'fully' loaded in order to prevent expression changed after checked errors caused by updating the column collection. More unit tests updates.
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
|
All the issues described in my previous comment are fixed except that in the 4th checkbox. But a new issue is introduced. When open the "Export" button an error is thrown: |
damyanpetev
reviewed
Nov 4, 2020
| }; | ||
|
|
||
| const moveTemplateIfAny = (grid: Element) => { | ||
| const ngTemplates = findElementNodes([grid], ['ng-template']); |
There was a problem hiding this comment.
It's possible for the template to be using the short syntax (<div *igxToolbarCustomContent...) that won't be found searching for just ng-template. As far as I see most of our code examples are covered, but to be thorough, try to capture both versions if it doesn't get too messy.
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-hiding.component.html
Outdated
Show resolved
Hide resolved
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
Aleksandyr
added
✅ status: verified
…into rkaraivanov/toolbar-refactor
ChronosSF
previously approved these changes
Nov 6, 2020
…into rkaraivanov/toolbar-refactor
…iteUI/igniteui-angular into rkaraivanov/toolbar-refactor
ChronosSF
approved these changes
Nov 6, 2020
zdrawku
approved these changes
Nov 6, 2020
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8055
Closes #7924
Closes #6858
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)