Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Toolbar refactoring #8055

Closed
wnvko opened this issue Aug 27, 2020 · 2 comments · Fixed by #8158
Closed

Grid Toolbar refactoring #8055

wnvko opened this issue Aug 27, 2020 · 2 comments · Fixed by #8158
Assignees
Labels
grid: general grid: toolbar 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Aug 27, 2020

Is your feature request related to a problem? Please describe.

Right now if you need to show IgxToolbar you should set showToolbar to true. However if you enable columnHiding, columnPinnig, exportExcel or exportCsv inputs in the grid nothing will change if shorToolbar is set to false.

Additionally you can template the toolbar by adding ng-template with igxToolbarCustomContent directive.

What is better is to have igxToolbar component and to be able to put this component in the grid. It could has its own inputs like exportExcel, exportCsv and so on. The new component should be easily templateable too. Right now there is no easy way to show column hiding in the toolbar and to the right of it some other content. There is also no way to change the order and location of column hiding, column pinning and export are shown.

Describe the solution you'd like

Add igxToolbar component and allow to add it as a child to the IgxGrid, the same way pager is working. Allow customizing of the toolbar, e.g. show column hiding, column pinning and export buttons with child components as this is done in the IgxCard.

@kdinev
Copy link
Member

kdinev commented Sep 14, 2020

As part of this work item, please also implement #6858

@StefanIvanov
Copy link
Contributor

spec has been updated to account for the responsive design behavior of the toolbar content

@zdrawku zdrawku added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 6, 2020
zdrawku added a commit that referenced this issue Nov 6, 2020
* feat(grid-toolbar): Toolbar refactor

Closes #8055

* feat(grid-toolbar): Hierarchical grid implementation

Closes #8055

* refactor(grid-toolbar): Correctly grid context
through templates in hierarchical grid

* fix(grid): Deselect columns for hiding

Change the interaction for column hiding UI.
Updated tests.

Closes #6858

* feat(grid): Emit when the grid is fully available in the DOM

Closes #7924

* refactor(toolbar): Hierachical grid tweaks.
Toolbar actions are rendered once the grid is 'fully' loaded in order to
prevent expression changed after checked errors caused by
updating the column collection.
More unit tests updates.

* chore(*): Dev demos updates

* refactor(toolbar): Toolbar unit tests

* refactor(tests): More unit tests

* refactor(toolbar): Tests, api docs and tweaks

* style(toolbar): provide styling for grid toolbar component

* refactor(*): Unit tests

* refactor(*): More unit tests

* chore(styling): run stylelint --fix

* refactor(toolbar): Even more unit tests

* style(toolbar): update elevations, border & title width

* update dropdowns border

* refactor(toolbar): remove unnecessary selectors

* refactor(toolbar): change elevation variable

* docs(toolbar): remove unnecessary requires from sass docs

* feat(grid-toolbar): Add basic migrations

* feat(toolbar): Clean up migrations
Migrate the toolbar based on the old input prop value

* fix(migrations): File changes ordering

* feat(toolbar): Template directive migration

* fix(toolbar): Focus action comp input on open
Remove filtering overlay keydown `catch'em all` handler.

* feat(toolbar): Hierarchical grid migrations

* fix(toolbar): Migration binding on empty directives

* feat(toolbar): Migrate template context bindings

* fix(toolbar): Backward compatible props

* chore(toolbar): Unit tests tweaks

* fix(toolbar): Toolbar width growing with pinned area

* fix(toolbar): Expression changed error

* fix(toolbar): Dropdown max height

* fix(toolbar): Skip excel export dropdown

* fix(toolbar): Choppy toggling of toolbar elements

* refactor(toolbar): Address review comments

Co-authored-by: Silvia Ivanova <SIvanova@infragistics.com>
Co-authored-by: Zdravko Kolev <zkolev@infragistics.com>
Co-authored-by: Stamen Stoychev <sstoychev@infragistics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general grid: toolbar 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants