Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Banner Component #1185

Merged
merged 20 commits into from
Jun 11, 2024
Merged

Add Banner Component #1185

merged 20 commits into from
Jun 11, 2024

Conversation

RivaIvanova
Copy link
Member

Closes #1174

Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise LGTM.

However, can you fix both the CI and the storybook builds as of now I cannot really "play" with the component?

src/components/banner/banner.spec.ts Outdated Show resolved Hide resolved
src/components/banner/banner.spec.ts Outdated Show resolved Hide resolved
src/components/banner/banner.ts Show resolved Hide resolved
src/components/banner/banner.ts Outdated Show resolved Hide resolved
@AnjiManova
Copy link

Material, Fluent and Bootstrap

Paddings are fine -> 8px (left and right) to the igx-banner, 8px (left and right) to the igx-banner _message and 16px top and bottom.

@rkaraivanov rkaraivanov merged commit aa8d2a2 into master Jun 11, 2024
5 checks passed
@rkaraivanov rkaraivanov deleted the rivanova/feat-banner-1174 branch June 11, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner component
8 participants