Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have created a PR to pass along some (what I would consider) important updates to this package.
Current Issues:
With the HTTP API, Auth headers are not passed reducing the quantity of requests I can make to unauthenticated endpoints by half.
Additionally, upon inspection of the code, I found the use of
setTimeout
before a request is invoked. This will delay any request by 10ms minimum and doesn't always happen.I have still received 429s using this package. Therefore, I am unsure if the timeout functionality is working correctly, however, that is not addressed in this PR.
With the WS API, it is a known issue that BitMEX will close websockets when many trades take place. There is no listener appended to the websocket to detect when the connection is closed.
Fixes:
setTimeout
if necessaryrefresh()
method for ping timeoutclose
eventI tested the code, but didn't create any tests since none existed previously. I figure that falls outside the scope of this PR.