BS5 vorbereitung #962
Closed
BS5 vorbereitung #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versionskontrolle BS5 Module und Layouts überarbeitet Vorbereitung für IlchCMS#454
blackcoder87
added a commit
that referenced
this pull request
Jun 23, 2024
5 tasks
blackcoder87
added a commit
that referenced
this pull request
Aug 7, 2024
- Code style improvements. - Remove curlOpt array as the stored cURL options where never used after saving them in that array. The way the options where stored wasn't useful either as a cURL option is "tied" to a specific transfer (transferUrl). This shouldn't affect the functionality as the important function call for cURL is curl_setopt(). - Remove getVersionsList() as it was only used in newVersionFound() of the transfer class itself and just one time. A second call was unnecessary. - Don't set zipFile in newVersionFound(). This caused an error (under PHP 8.2) and looks like it wasn't needed. - Verify file right before installing. - BS5 vorbereitung #962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Versionskontrolle BS5
Module und Layouts überarbeitet
Vorbereitung für #454
Type of change
This PR has been tested in the following browsers: