Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies with the VCF Specification #27

Closed
brmyers opened this issue Nov 26, 2018 · 3 comments
Closed

Discrepancies with the VCF Specification #27

brmyers opened this issue Nov 26, 2018 · 3 comments

Comments

@brmyers
Copy link

brmyers commented Nov 26, 2018

Thanks for the software. While using it, I discovered two items that are not following the VCF specification.
https://samtools.github.io/hts-specs/VCFv4.2.pdf

  1. Commas are used to delimit the ID field, and the specification states semicolons (page 4)
  2. "GQ" is already a reserved keyword in the FORMAT field (page 6)

I'm doing some post-processing as a workaround, but figured I'd mention my findings.

Best,
Ben

@KelleyRyanM
Copy link
Contributor

@brmyers ,
Good point about the ID delimiter.

The use of the GQ field for genotype information was intentional. Admittedly, the specification indicates this should be a phred-scaled quality score, which is not true of the array quality scores; however, there is some benefit to re-using the "standard" field for quality information.

@KelleyRyanM
Copy link
Contributor

Created pull request at #29

@brmyers
Copy link
Author

brmyers commented Nov 28, 2018

Fair point about reusing GQ @KelleyRyanM, but it's worth mentioning that htsjdk (not sure about other VCF libraries) changes the GQ/Format header to an integer and rounds the values in the records to zero or one.

Appreciate the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants