Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newell/better configuration #11

Merged
merged 110 commits into from Nov 21, 2018
Merged

Newell/better configuration #11

merged 110 commits into from Nov 21, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2018

Refactor configuration mechanisms and build more robust configuration file handling.

Andrew Newell added 30 commits September 19, 2018 13:45
intermediate refactor to remove older_than config and use minimmum_ta…
cae0b20 
…ble_threshold
building minimum table limit
14bfd3d
bad logic, needs to be broken down and abstracted
df26b42
going insane with config stuff. Need tests
3a79be8
going insane with config stuff. Need tests
2b45f6d
this isn't the right approach
40c61c0
revised configuration to just get approved tables from a config file
f5422a9
created approved_tables and table objects to help manage configuratio…
4d36706 
…n data
broken everything trying to convert to using tables
808f728
fixed bad calls to partition_table
4aede3f
adding tests for approved_tables
63cf580
refining behavior for approved_tables
976cc33
more refactoring of contracts
f2ab7f8
incremental fixes to tests
8fbf402
bumped pgslice version
fd808a0
tweaks to logging
3a60b7d
adjust param behavior and log levels
a3f8bfa
tests pass. I don't believe it though
762a5e8
rubocop
a5ac8e5
attempting to simplify things
7635341
fixed complexity whining. This is not less complex
da24552
tweak config examples
7791e53
add exception for parameter list in table.rb
dea8331
build test to see if future date lookbacks work. remove commented code
abf21e0
remove commented code
0593e6d
extract error classes into separate file. Add comments. rewrite confi…
12a75af 
…guration_file_loader
writing tests for configuration_file_loader
572044e
make approved_tables and table comparable
977530e
add tests for configuration file issues. Check default configurations
26d4b62
remove additional_validators, make configuration_file_loader take config
b4c1375
Andrew Newell added 21 commits November 20, 2018 19:10
fix tests by forcing postgres to use UTC
3bc9747
update readme
87b8b69
remove logger readme entry since it doesn't behave consistently yet
424afb4
safely convert year and month tables to first of the month dates
88a9e52
safely parse monthly and yearly dates
2a9d9cb
another successful refactor. Pulled out date stuff into date helper
a52f61d
all tests actually pass
3899452
code golf
c30afa7
extract period_fetcher
ace7d7e
rubocop is happy
695c1c9
remove unused method and remove bang from partition_table
101eb3e
round out partition_manager_tests
a36d8be
unhealthy obsession with low-hanging-tests. It's fucking easy. Ruby i…
044b6c0 
…s amazing.
allow asserts on tables using pgtable info
d662b82
build helper around database_connection to log duration
0b80656
add duration logging to pg_slice stuff
06bfaeb
improve logs by reducing whitespace
b37912a
reduce cognitive complexity? dafuq
0b220a2
fuck you cognitive complexity my ass
49e6049
support ad-hoc dry-run for pgslice commands
1044952
write pg_slice_manager_test to capture missing dry_run behavior
f226a09
@ghost
Copy link
Author

ghost commented Nov 21, 2018

Those codeclimate issues are stupid

@ghost
Copy link
Author

ghost commented Nov 21, 2018

fixes #6 #8

@scytherswings
Copy link
Contributor

The duplication isn't that much of a concern. This is ready to go.

@scytherswings scytherswings merged commit c455b4e into IlluminusLimited:master Nov 21, 2018
This was referenced Nov 21, 2018
Closed
Closed
@ghost ghost deleted the newell/better_configuration branch December 7, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @scytherswings