Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c31, c32 and updated c33 #48

Merged
merged 7 commits into from
Apr 26, 2021
Merged

c31, c32 and updated c33 #48

merged 7 commits into from
Apr 26, 2021

Conversation

ScrewThisNoise
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some potential issues. I didn't check inside every file, but it looks like there are no other whitespace changes, they were isolated to the first commit in the PR (the fix one).

//「付いてこい……だ? 何処に、何の目的で行くんだ?」=
//「いやそれは、まだ秘密という事で……サプライズ的な?」=
//「怪しさしかないが……まぁいいだろう。おまえに釣られてみるというのも、面白そうだしな」=
「付いてこい……だ? 何処に、何の目的で行くんだ?」="""Follow me""... you say? Where, and for what reason?"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote issues

「このまま一緒にやっていたら、二人で学園トップの秀才になっちゃうかもね」=If we keep doing it together like this, we might end up becoming the top prodigies in this school.
「おまえはすぐそうして調子に乗る。頭が良くても、賢くなければ意味がないのだぞ?」=You always get carried away at the drop of a hat like that. Even if you have a good head, if you don't have street smarts, there's no point, you know?
「ははっ、なんかお母さんみたいな事言われちゃったね」=Haha--, you sound like you're my mother.
「お、おかっ!? そこはせめて、おねーさんと言え!」="M-Moth--!? Atleast say ""elder sister"" instead!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote issues

Copy link
Collaborator

@GeBo1 GeBo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got through the first 80 files or so, but there seems to be issues with lines with " in them.

They come out like this:

="""blah blah"", he said."

Rather than:

="blah blah", he said.

Also if it's simple enough could you restore the line of whitespace separating the CHOICE: entries so the diffs line up?

@ManlyMarco
Copy link
Collaborator

ManlyMarco commented Apr 25, 2021

@GeBo1 Fixed both of these issues, looks like it's ready to merge.
Adding extra lines around CHOICE: caused some other diff noise but it seems to be much less than before. There are still some empty lines removed, but these can't be restored programmatically I think.

@GeBo1 GeBo1 merged commit 8f03a90 into IllusionMods:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants