Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing c23, c36 and OP translations #96

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Add some missing c23, c36 and OP translations #96

merged 2 commits into from
Sep 22, 2022

Conversation

ManlyMarco
Copy link
Collaborator

Gathered separate translation dictionaries for each personality and then used them to fill in missing translations within these personalities. This is to avoid using translations from different personalities since they could be different.

@ManlyMarco ManlyMarco changed the title Fill in untranslated duplicate/overriden lines within personalities Fill in untranslated overriden lines within personalities Sep 7, 2022
@ManlyMarco ManlyMarco changed the title Fill in untranslated overriden lines within personalities Add some missing c23, c36 and OP translations Sep 22, 2022
Copy link
Collaborator

@GeBo1 GeBo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggesting one change.

…c36/20/303/translation.txt

Co-authored-by: GeBo1 <57293591+GeBo1@users.noreply.github.com>
@GeBo1 GeBo1 merged commit cd52f22 into master Sep 22, 2022
@ManlyMarco ManlyMarco deleted the fill-holes branch September 22, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants