Shoe warp: fix communication #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon entering a Communication scene, the shoe state was getting reset sufficiently to wipe out the changes we made to the bind poses, but not sufficiently to cause our dirty flag to get set. The animation state does get reset in this case, so we can reuse that detection to avoid breakage.
ManlyMarco
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon entering a Communication scene, the shoe state was getting reset sufficiently to wipe out the changes we made to the bind poses, but not sufficiently to cause our dirty flag to get set. The animation state does get reset in this case, so we can reuse that detection to avoid breakage without having to recalculate every frame.
Let me know if you think the performance impact of this fix is problematic; I suspect it would be possible to cache the warped matrix in the same way that we cache the base matrix (but without concurrency), which would probably speed things up a bit if needed.