Convert the testmethod modifier to the @IsTest annotation
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.22% // Head: 99.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## ilyamatsuev/dev #19 +/- ##
================================================
Coverage 99.22% 99.22%
================================================
Files 7 7
Lines 2693 2706 +13
Branches 586 593 +7
================================================
+ Hits 2672 2685 +13
Misses 20 20
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
IlyaMatsuev
deleted the
feature/convert-testmethod-modifier-to-annotaiton
branch
IlyaMatsuev
added a commit
that referenced
this pull request
Feb 11, 2023
* private is added to method params if they are final (#15) * Remove default access modifier handling for parameters * Update changelog * webservice modifier conflicts with apexExplicitAccessModifier (#16) * Make webservice and testmethod always lowercase * Exclude webservice methods from setting default modifier * Sync with upstream (#17) * Update dependency @types/node to v18.11.8 * Update typescript-eslint monorepo to v5.42.0 * Update dependency @types/jest to v29.2.1 * Update dependency @types/node to v18.11.9 * Update dependency @types/jest to v29.2.2 * Updated jorje (dangmai#687) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency eslint to v8.27.0 * Update typescript-eslint monorepo to v5.42.1 * Update dependency jest to v29.3.0 * Update dependency ts-migrate to v0.1.35 * Update dependency jest to v29.3.1 * Fix dangmai#693 - Binaryish expressions having wrong indentations inside parentheses * Add comment about input parameter handling * Remove ts-migrate dependency * Fix dangmai#688 - Keep original position for comments in-between If-Else and Try-Catch blocks * Update typescript-eslint monorepo to v5.43.0 * Update dependency @types/jest to v29.2.3 * Update dependency typescript to v4.9.3 * Fix dangmai#698 - Add breaking change about script location to CHANGELOG * Updated jorje (dangmai#701) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency eslint to v8.28.0 * Update typescript-eslint monorepo to v5.44.0 * Update peter-evans/create-pull-request action to v4.2.1 * Update dependency prettier to v2.8.0 * Update peter-evans/create-pull-request action to v4.2.2 * [vscode] remove NPM extension from recommendation * Updated jorje (dangmai#707) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Updated jorje (dangmai#708) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update peter-evans/create-pull-request action to v4.2.3 * Update typescript-eslint monorepo to v5.45.0 * Update dependency @types/node to v18.11.10 * Update dependency eslint to v8.29.0 * Use `yarn` instead of `npm` for dep management * Use yarnhook to streamline dev dependency installation * Fix Jest globalSetup & globalTeardown not working correctly * Fix ESLint issues with start & stop test server scripts * Fix ESLint issues with start and stop apex server scripts * Add package tests * Fix run-package-tests errors * Add missing closing parenthesis to Workflow * Remove extraneous '--' in Yarn commands * Final CHANGELOG for 1.12.0 * 1.12.0 * Fix ignore-list.txt location * Fix path to EDA unpackaged directory * Add workaround for INPUT_TOKEN env var not being populated * Update dependency @types/jest to v29.2.4 * Update typescript-eslint monorepo to v5.45.1 * Update dependency @types/node to v18.11.11 * Update dependency prettier to v2.8.1 * Update dependency typescript to v4.9.4 * Update typescript-eslint monorepo to v5.46.0 * Update dependency @types/node to v18.11.12 * Updated jorje (dangmai#724) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Add optional start-apex-server flag for allowed CORS origins * Pipe apex-ast-serializer logs to console * Fix linting issue with files not formatted correctly * Update dependency @types/node to v18.11.13 * Install husky hooks in postinstall * Use new husky syntax * Update typescript-eslint monorepo to v5.46.1 * Update dependency @types/node to v18.11.14 * Update dependency @types/node to v18.11.15 * Updated jorje (dangmai#725) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency @types/node to v18.11.16 * Update dependency eslint to v8.30.0 * Update dependency @types/node to v18.11.17 * Update dependency wait-on to v7 (dangmai#730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v5.47.0 * Update husky scripts * Fix tests * Add examples Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dang Mai <contact@dangmai.net> Co-authored-by: dangmai <dangmai@users.noreply.github.com> * A modifier is deleted from the method declaration when annotation is followed by a comment (#18) * Fix dangling comments for apexSortModifiers option * Include sfdx folder to gitignore * Update changelog * Convert the `testmethod` modifier to the `@IsTest` annotation (#19) * Replace testmethod modifier with the annotation * Replace testmethod with @istest * Fix unit tests * Make the testmethod modifier convertion optional * Update changelog * Update build status badge * Prevent apexExplicitAccessModifier feature for triggers (#21) Co-authored-by: Ilya Matsuev <ilya.matsuev@kpn.com> * Update changelog for the latest bugfix * Sync with upstream (#23) * Update dependency @types/node to v18.11.8 * Update typescript-eslint monorepo to v5.42.0 * Update dependency @types/jest to v29.2.1 * Update dependency @types/node to v18.11.9 * Update dependency @types/jest to v29.2.2 * Updated jorje (dangmai#687) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency eslint to v8.27.0 * Update typescript-eslint monorepo to v5.42.1 * Update dependency jest to v29.3.0 * Update dependency ts-migrate to v0.1.35 * Update dependency jest to v29.3.1 * Fix dangmai#693 - Binaryish expressions having wrong indentations inside parentheses * Add comment about input parameter handling * Remove ts-migrate dependency * Fix dangmai#688 - Keep original position for comments in-between If-Else and Try-Catch blocks * Update typescript-eslint monorepo to v5.43.0 * Update dependency @types/jest to v29.2.3 * Update dependency typescript to v4.9.3 * Fix dangmai#698 - Add breaking change about script location to CHANGELOG * Updated jorje (dangmai#701) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency eslint to v8.28.0 * Update typescript-eslint monorepo to v5.44.0 * Update peter-evans/create-pull-request action to v4.2.1 * Update dependency prettier to v2.8.0 * Update peter-evans/create-pull-request action to v4.2.2 * [vscode] remove NPM extension from recommendation * Updated jorje (dangmai#707) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Updated jorje (dangmai#708) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update peter-evans/create-pull-request action to v4.2.3 * Update typescript-eslint monorepo to v5.45.0 * Update dependency @types/node to v18.11.10 * Update dependency eslint to v8.29.0 * Use `yarn` instead of `npm` for dep management * Use yarnhook to streamline dev dependency installation * Fix Jest globalSetup & globalTeardown not working correctly * Fix ESLint issues with start & stop test server scripts * Fix ESLint issues with start and stop apex server scripts * Add package tests * Fix run-package-tests errors * Add missing closing parenthesis to Workflow * Remove extraneous '--' in Yarn commands * Final CHANGELOG for 1.12.0 * 1.12.0 * Fix ignore-list.txt location * Fix path to EDA unpackaged directory * Add workaround for INPUT_TOKEN env var not being populated * Update dependency @types/jest to v29.2.4 * Update typescript-eslint monorepo to v5.45.1 * Update dependency @types/node to v18.11.11 * Update dependency prettier to v2.8.1 * Update dependency typescript to v4.9.4 * Update typescript-eslint monorepo to v5.46.0 * Update dependency @types/node to v18.11.12 * Updated jorje (dangmai#724) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Add optional start-apex-server flag for allowed CORS origins * Pipe apex-ast-serializer logs to console * Fix linting issue with files not formatted correctly * Update dependency @types/node to v18.11.13 * Install husky hooks in postinstall * Use new husky syntax * Update typescript-eslint monorepo to v5.46.1 * Update dependency @types/node to v18.11.14 * Update dependency @types/node to v18.11.15 * Updated jorje (dangmai#725) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency @types/node to v18.11.16 * Update dependency eslint to v8.30.0 * Update dependency @types/node to v18.11.17 * Update dependency wait-on to v7 (dangmai#730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v5.47.0 * Update dependency @types/node to v18.11.18 * Update typescript-eslint monorepo to v5.47.1 * Update dependency @types/jest to v29.2.5 * Update dependency eslint to v8.31.0 * Update dependency eslint-config-prettier to v8.6.0 * Update typescript-eslint monorepo to v5.48.0 * Update dependency husky to v8.0.3 * Update actions/setup-node action to v3.6.0 * Update dependency prettier to v2.8.2 * Bump json5 from 1.0.1 to 1.0.2 (dangmai#745) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v5.48.1 * Update dependency ts-jest to v29.0.4 * Update dependency eslint-plugin-import to v2.27.4 * Update dependency ts-jest to v29.0.5 * Update dependency prettier to v2.8.3 * Update dependency rimraf to v4 (dangmai#751) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency rimraf to v4.0.5 * Updated jorje (dangmai#735) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency eslint to v8.32.0 * Update dependency rimraf to v4.0.7 * Update typescript-eslint monorepo to v5.48.2 * Update dependency eslint-plugin-import to v2.27.5 * Update dependency rimraf to v4.1.0 * Update dependency rimraf to v4.1.1 * Update dependency @types/jest to v29.2.6 * Update typescript-eslint monorepo to v5.49.0 * Update dependency rimraf to v4.1.2 * Update dependency jest to v29.4.0 * Update dependency @types/jest to v29.4.0 * Update dependency jest to v29.4.1 * Update dependency eslint to v8.33.0 * Update dependency typescript to v4.9.5 * Update typescript-eslint monorepo to v5.50.0 * Updated jorje (dangmai#771) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency @types/node to v18.11.19 * Update typescript-eslint monorepo to v5.51.0 * Updated jorje (dangmai#774) Co-authored-by: dangmai <dangmai@users.noreply.github.com> * Update dependency @types/node to v18.13.0 * Update dependency jest to v29.4.2 * Update dependency prettier to v2.8.4 * [chore] enable renovate lockFileMaintenance * [chore] fix renovate config * Lock file maintenance * Update dependency eslint to v8.34.0 * Fix vendor jars --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dang Mai <contact@dangmai.net> Co-authored-by: dangmai <dangmai@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dang Mai <contact@dangmai.net> Co-authored-by: dangmai <dangmai@users.noreply.github.com> Co-authored-by: Ilya Matsuev <ilya.matsuev@kpn.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all
testmethodmodifiers be deleted and replaced with the@IsTestannotation if theapexFormatAnnotationsoption is enabled.CHANGELOG.mdfile in theUnreleasedsection.