ShaderNetworkAlgo::removedUnusedShaders : Optimize, fix crash in case of cycle #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Daniel, LGTM (apart from a missing Changes.md entry, which I'll add after merging). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a crash in my testing of ShaderTweakProxy - we will quite possibly need to add an explicit cycle check to that code, because I'm guessing we don't want to depend on renderers behaving reasonably when handed shader networks containing cycles. But it probably still makes sense to merge this, because it's currently easy to cause a crash in this function by building a shader network with the Python API, and also in extreme cases this could be dramatically faster ( because it avoids revisiting subgraphs that have already been checked ).