Use user defined allocator/deallocator #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its OK to utilize Acquire/RelinquishMagickMemory() in the opencl.c/memory.c source modules, however, malloc() must remain in the semaphore.c source module. Since we cannot apply your entire pull request, we'll selectively apply your patch. |
urban-warrior
pushed a commit
that referenced
this pull request
Jun 5, 2019
|
@urban-warrior Thank you for applying a patch. I found a typo. Please fix it ( a7ae3f4#r33815166 ) |
|
@urban-warrior Even without fixing semaphore.c, seems it brings big impact to our memory management 🎉 Thanks a lot. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 11, 2019
2019-06-08 7.0.8-49 Cristy <quetzlzacatenango@image...>
* Release ImageMagick version 7.0.8-49, GIT revision 15708:6d7e1db:20190608
2019-06-03 7.0.8-49 Cristy <quetzlzacatenango@image...>
* Add support for RGB565 image format (reference
https://imagemagick.org/discourse-server/viewtopic.php?f=2&t=36078).
* Use user defined allocator instead of `malloc` (reference
ImageMagick/ImageMagick6#49).
* Add static decorator to accelerator kernels (reference
ImageMagick/ImageMagick#1366).
2019-06-01 7.0.8-48 Cristy <quetzlzacatenango@image...>
* Release ImageMagick version 7.0.8-48, GIT revision 15689:061a3bb82:20190601
2019-06-01 7.0.8-48 Cristy <quetzlzacatenango@image...>
* Fix transient convolution bug (reference
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=36119).
2019-05-26 7.0.8-47 Cristy <quetzlzacatenango@image...>
* Release ImageMagick version 7.0.8-47, GIT revision 15681:5cffc6cbb:20190526
2019-05-19 7.0.8-47 Cristy <quetzlzacatenango@image...>
* Support 16 and 32 bit tiled float TIFF images.
* Convolve morphology alpha channel fix (reference
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=36086).
* Text improvements to the internal SVG renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, I'm fighting to reduce memory usage in RMagick which is Ruby ImageMagick bridging.
To work Ruby's GC correctly, we need to know ImageMagick allocated memory size at runtime.
Because Ruby decides whether to run GC by current memory usage.
And the memory usage need to contain Ruby bridging (RMagick) and library (ImageMagick).
If it could notify total allocated memory size (RMagick + ImageMagick) to Ruby correctly,
Ruby's GC will work well and reduce application memory usage.
So, if ImageMagick has used Ruby's allocator configured by SetMagickMemoryMethods(),
Ruby can calculate the memory usage automatically.
This PR makes it possible to refer to a user defined allocator in where using
malloc/freedirectly.By this PR, it reduce RMagick memory usage from blue line to red line.
Related to rmagick/rmagick#697