Changed LPOP to BLPOP in file redis_store.go #63
Conversation
…rable in config.yml, default timeout is 10 seconds
| @@ -37,6 +37,9 @@ redis_activity_consumers: 8 | |||
| # Number of concurrent connections to Redis in the connection pool. | |||
| redis_connection_pool_size: 20 | |||
|
|
|||
| # Max number of seconds BLPOP waits before returning anyway. Must be a positive integer. 0 means wait indefinitely. | |||
| redis_blpop_timeout: 10 | |||
There was a problem hiding this comment.
why not wait indefinitely by default so when a message is there incus resolves it instantly? (unless this blocks redis somehow ofc)
There was a problem hiding this comment.
because I wanted a "safe" value for all the possible environments, I'm not sure that zero has no side effects. Anyway the change is trivial so let me know if I have to change it to zero.
There was a problem hiding this comment.
not a redis user so no idea if it would be safe or not, why I asked :P
There was a problem hiding this comment.
I think this should be 0, not sure about the polling implementation but either you repoll on timeout or just blpop 0, also make sure to use a different connection for this since the command will block the whole connection so you can't run any other commands on it!
There was a problem hiding this comment.
I closed this pr, new pr opened with this value with default at 0.
Look here #73
There was a problem hiding this comment.
you now you can just add commits to the branch and the PR will update right?
There was a problem hiding this comment.
my mistake, sorry
|
|
samuelebistoletti
changed the title
I created a new pull request with BLPOP change in redis_store.go as requested yesterday. Timeout interval is now configurable in config.yml.