Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline fix for paq script on windows #144

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

Hejsil
Copy link
Contributor

@Hejsil Hejsil commented Jun 5, 2020

This is my attempt and fixing this very unfortunate problem. Anyone with a windows installation that wants to help test this can do the following:

git clone https://github.com/Hejsil/Nuklear-1.git
cd Nuklear-1/src
git checkout newline-fix
paq.bat
git diff

git diff should hopefully show that nothing changed. If @zgcrowno could test this that would be great!

@zgcrowno
Copy link
Contributor

zgcrowno commented Jun 5, 2020

@Hejsil, git diff does seem to show that nothing has changed with this build.

@dumblob
Copy link
Member

dumblob commented Jun 6, 2020

Sorry for the delay. LGTM, please merge 😉.

@Hejsil Hejsil merged commit bbae32e into Immediate-Mode-UI:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants